Jsonb support #26
Open
Jsonb support #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prettier made a mess. Fixed.
|
can we get this PR from this kind gentleman in? @Edsol @dankochetov @Sukairo-02 🙏 |
|
Is the repo maintained? |
|
I'm going to say, based on the evidence, not so much. That's why I forked and created my own version of this. See #25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went ahead and added support for JSON data for PostgreSQL. Should address #25
Note there's currently a bug in Drizzle-ORM that prevents some of the tests from passing. I've temporarily set those tests to
.skip()so that the tests pass. I understand that's not ideal, but having tests fail for a PR for unrelated reasons is also not ideal. I did test a completely clean version of the repo, and the same tests still failed.