allow empty dbgenerated attribute #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some developers have added empty
dbgenerated()attributes to their schema to support GENERATED columns in postgres. See prisma/prisma#20077Prior to the changes in tjis PR,
drizzle-prisma-generatorwill throw an error whendbgenerated()is empty.The error message is largely unhelpful, because there isn't an easy way to get the stack-trace from the prisma cli. However by examining the code you can see that the dbgenerated handling expects there always to be an argument for this attribute.
This change allows for empty dbgenerated attributes (no arg), and declares them as GENERATED columns. We use a dummy SQL for the generated expression, since we have no way of knowing the actual expression or value the developer actually used.