chore!: bump embedded-hal-async to 1.0.0
#1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROMemories
changed the title
embedded-hal-async to 1.0.0embedded-hal-async to 1.0.0
BREAKING CHANGE: requires the I2C driver to impl a newer trait.
ROMemories
force-pushed
the
chore/bump-embedded-hal-async
branch
from
a9c9fd0 to
a0f7789
Compare
|
Thanks for merging #3! I can rebase this branch if needed, but it doesn't seem necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thank you for your work on this crate!
This bumps the
embedded-hal-asyncdependency sohts221-asynccan easily be used with other crates from that version.hts221-asyncstill seems to be the most recently maintained crate for that sensor.I think this is a breaking change as
Hts221now requires an I2C driver implementing a newer trait.We do have a use case for this crate at Ariel OS.
Testing
I had a cursory look at the imported items but it wasn't so easy because of the wildcard imports. This does however work for me in hardware, at least for
read()ing a value on a instantiated and initializedHts221driver.