Skip to content

Conversation

@GoodGuysFree
Copy link

Hi,

I'd like to suggest these 2 commits, to support unicode pathnames, and to help with fstab installs, by letting a non-root user mount an fstab-configured Google Drive filesystem.

Hope you'll consider these.

Thanks,

Amit Margalit added 2 commits February 19, 2016 18:26
… option

into fstab, so anyone can mount the filesystem, if they have access to the
creds file...
@je-vv
Copy link

je-vv commented Jul 16, 2016

For the newest release 0.14.8 your commit for ut8 requires changes.

The new patch just keeps the normal_entry.py modifications, given the opened_file.py ones are no longer required, neither match the current code:

https://github.com/dsoprea/GDriveFS/files/367583/pull_154_utf8.txt

@GoodGuysFree
Copy link
Author

I agree that the first part of d6d8055 (gdrivefs/gdfs/opened_file.py) is no longer needed.
I am not sure about gdtool, but generally, encoding to ASCII can be problematic at times.

I feel this commit can be omitted completely.

Commit de2ce14 however, I feel is still useful.

v = True

# ignore the "user" option so we can put in fstab easily
if k == "user":
Copy link
Owner

@dsoprea dsoprea Jul 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear on why we need this. If we receive an unsupported option, it's just forwarded to FUSE. In this case, there is no such "user" option. So, it should work fine without this change.

Copy link
Author

@GoodGuysFree GoodGuysFree Jul 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a previous version I received an error when I put 'user' in the options in fstab, when I wanted to make mounting the GDriveFS user-mountable. I haven't used GDriveFS in a while, so I have no problem if you simply reject it. Sorry for causing a stir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants