Check for CRC or BIB on primary block #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #16 and also adds a test under
tests/security_tests.rs.One issue is the function
new_complete_bundle()intests/bundle_tests.rsreturns a Bundle without CRC and BIB protecting the primary block when getting passed the CrcRawType = 0.Therefore the following tests fail when running the tests with
--feature bpsec:bundle_tests()bundle_helpers()bundle_canonical_update_tests()bundle_add_cblock()status_report_tests()Question to the maintainers: Should these tests include a BIB protecting the primary block or should they receive the
#[cfg(not(feature = "bpsec"))]flag to only run when executing the tests without the BPSec feature?