add priority canonical block #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gh0st42
requested changes
Mar 20, 2023
Member
gh0st42
left a comment
gh0st42
left a comment
There was a problem hiding this comment.
thanks for the PR, some more documentation would be nice.
also a complete example on how to create a bundle and add the priority block would be a good thing for the documentation of the whole module.
| InvalidPriorityBlock, | ||
| } | ||
|
|
||
| // HOP_COUNT_BLOCK is a BlockType for a Hop Count block as defined in |
Member
There was a problem hiding this comment.
could you please add a comment describing the block a bit better?
don't follow my bad example :)
| pub const PRIORITY_BLOCK: CanonicalBlockType = 224; | ||
|
|
||
| #[derive(Debug, Clone, PartialEq, Serialize, Deserialize)] | ||
| pub struct PriorityBlockData(u16); |
Member
There was a problem hiding this comment.
a doc string describing the priority system would be nice. is lower better or higher?
it might make sense to have const's or enums for HIGHEST, LOWEST and MEDIUM priorities.
an even more convenient way for the API would be helpers to return a complete block, e.g., new_highest_priority_block, new_lowest_priority_block, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gh0st42