-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New DaxYellowPill custom view #7587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
21c5725 to
0519d12
Compare
...oid-design-system/design-system/src/main/java/com/duckduckgo/common/ui/view/DaxYellowPill.kt
Show resolved
Hide resolved
android-design-system/design-system/src/main/res/values/design-system-dimensions.xml
Show resolved
Hide resolved
| <dimen name="infoPanelIconSize">16dp</dimen> | ||
|
|
||
| <!-- Yellow Pill --> | ||
| <dimen name="yellowPillHeight">16dp</dimen> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍Designs say height is 15dp....which is a strange number to me. I think 16 is better but maybe we want to be sure?
android-design-system/design-system-internal/src/main/res/layout/component_one_line_item.xml
Show resolved
Hide resolved
...oid-design-system/design-system/src/main/java/com/duckduckgo/common/ui/view/DaxYellowPill.kt
Show resolved
Hide resolved
android-design-system/design-system-internal/src/main/res/layout/component_one_line_item.xml
Show resolved
Hide resolved
mikescamell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this so I don't block you ✅
We need to clarify the size issue with design and I would recommend that we fix the text size to 11dp to prevent font sizing breaking layouts, for now.
Nice work! ![]()

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211997802813789?focus=true
Description
New DaxYellowPill custom view created to replace the current yellow pill that it is an image
Steps to test this PR
UI changes
Note
Introduces a reusable, text-based yellow pill component to replace static image pills.
DaxYellowPill(AppCompatTextView) with pill styling, all-caps single line, and support forandroid:textvia styleable attrs plussetPillTexthelpersbackground_yellow_pilldrawable andyellowPillHeight/yellowPillPaddingHorizontaldimensions; declaresDaxYellowPillattrscomponent_one_line_item.xmlpreview to include an example row usingDaxYellowPillWritten by Cursor Bugbot for commit 0519d12. This will update automatically on new commits. Configure here.