Skip to content

Conversation

@nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Jan 26, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211997802813789?focus=true

Description

New DaxYellowPill custom view created to replace the current yellow pill that it is an image

Steps to test this PR

  • Go to Settings > Design System Preview
  • Go to List items
  • Check Yellow pill for "Item with New Custom View YellowPill" looks correct

UI changes

Screenshot 2026-01-26 at 18 08 49

Note

Introduces a reusable, text-based yellow pill component to replace static image pills.

  • Adds DaxYellowPill (AppCompatTextView) with pill styling, all-caps single line, and support for android:text via styleable attrs plus setPillText helpers
  • New resources: background_yellow_pill drawable and yellowPillHeight/yellowPillPaddingHorizontal dimensions; declares DaxYellowPill attrs
  • Updates component_one_line_item.xml preview to include an example row using DaxYellowPill

Written by Cursor Bugbot for commit 0519d12. This will update automatically on new commits. Configure here.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mikescamell mikescamell self-assigned this Jan 27, 2026
@nalcalag nalcalag force-pushed the feature/noelia/custom_yellow_pill_view branch from 21c5725 to 0519d12 Compare January 27, 2026 10:35
@nalcalag nalcalag marked this pull request as ready for review January 27, 2026 11:19
<dimen name="infoPanelIconSize">16dp</dimen>

<!-- Yellow Pill -->
<dimen name="yellowPillHeight">16dp</dimen>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍Designs say height is 15dp....which is a strange number to me. I think 16 is better but maybe we want to be sure?

Copy link
Contributor

@mikescamell mikescamell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this so I don't block you ✅

We need to clarify the size issue with design and I would recommend that we fix the text size to 11dp to prevent font sizing breaking layouts, for now.

Nice work! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants