Skip to content

Conversation

@Peter9192
Copy link
Collaborator

Made a start, but there's some bumps in the road.

        # TODO: what if data is NaN? Model-specific back-conversion? Don't convert to NaN in getters?
        # TODO: wflow not settable (rank mismatch, should be 2???!)
        # TODO: pcrglob discharge not settable (but works for temperature)
        # TODO: add tests like so:
        """
        name = 'temperature'
        da = model.get_value_as_xarray(name)
        orig = model.get_value(name)
        model.set_value_as_xarray(name, da)
        new = model.get_value(name)
        assert all(orig == new)
        """

Closes #182

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add set_value_as_xarray to models

2 participants