Skip to content

Adding the missing private label #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FlorianReimold merged 1 commit into from
Nov 4, 2025
Merged

Adding the missing private label #88

FlorianReimold merged 1 commit into from
Nov 4, 2025

Conversation

@ashhermirza
Copy link
Contributor

@ashhermirza ashhermirza commented Nov 2, 2025

Adding private label to the WriteableFile class definition.

Test:

  • Build tested on linux machine.

@ashhermirza
Copy link
Contributor Author

ashhermirza commented Nov 3, 2025

@FlorianReimold, while going through the code I found that WriteableFile in unix is missing the private label compared to the same class definition in win. Please let me know if you can merge this PR or need any change.

@FlorianReimold
Copy link
Member

FlorianReimold commented Nov 4, 2025

Thank you very much for finding this!

@FlorianReimold FlorianReimold merged commit 9687c1d into eclipse-ecal:master Nov 4, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ashhermirza @FlorianReimold