Use Bundle#getResources to discover embedded SPI resources #2137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@HannesWell : would be nice if you could review that. We should get the fix in RC1. |
HannesWell
approved these changes
Nov 18, 2025
Member
There was a problem hiding this comment.
Looks reasonable to me.
But due to a recent outage at Github regarding git operations I'm not able to fetch this change to try it locally. But from what I see in the web-UI this is fine.
Thanks for the fix.
I just have two style remarks, that would be nice to have.
...lipse.pde.junit.runtime/src/org/eclipse/pde/internal/junit/runtime/SPIBundleClassLoader.java
Outdated
Show resolved
Hide resolved
ui/org.eclipse.pde.junit.runtime/src/org/eclipse/pde/internal/junit/runtime/SPIMapping.java
Outdated
Show resolved
Hide resolved
Currently we use bundle.getEntry but this has some limitations, e.g. fragments and embedded jars. While the first can be avoided with findEntries, the second can not. As we previously already used bundle.getResources it seems fine to continue using that method.
HannesWell
approved these changes
Nov 20, 2025
Member
HannesWell
left a comment
HannesWell
left a comment
There was a problem hiding this comment.
Thanks for the updates.
Still look good to me :)
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use bundle.getEntry but this has some limitations, e.g. fragments and embedded jars.
While the first can be avoided with findEntries, the second can not. As we previously already used bundle.getResources it seems fine to continue using that method.
Fixes #2132