Skip to content

Conversation

@arunjose696
Copy link
Contributor

The calculated image zoom for the source image should be the same as the GCzoom(100) when the drawable of GC is not scalable

Steps to reproduce
Run the snippet in #2504
With source and destination at 1:2 the image would be cropped without this change

Fixes: #2504

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2025

Test Results

  118 files  ±0    118 suites  ±0   10m 42s ⏱️ +14s
4 440 tests +1  4 419 ✅ +2  17 💤 ±0  4 ❌  - 1 
  298 runs  ±0    290 ✅ +1   4 💤 ±0  4 ❌  - 1 

For more details on these failures, see this check.

Results for commit d892d79. ± Comparison against base commit cbf7f7a.

♻️ This comment has been updated with latest results.

@arunjose696 arunjose696 force-pushed the arunjose696/drawImageNonAutoScalable branch from e0927d3 to e696e5c Compare September 15, 2025 11:39
@akoch-yatta akoch-yatta force-pushed the arunjose696/drawImageNonAutoScalable branch from e696e5c to 2b1cc49 Compare September 18, 2025 06:18
@fedejeanne
Copy link
Member

Test failures are unrelated: #2516

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add a test for this to ensure that we do not accidentally run into the same situation again? Something like a simplified version of the snippet in #2504 with a very simple image in which you can easily assert based on specific pixel values if the image was properly sized or not.

@arunjose696 arunjose696 force-pushed the arunjose696/drawImageNonAutoScalable branch 2 times, most recently from 61f063d to deb956d Compare September 24, 2025 09:00
@arunjose696
Copy link
Contributor Author

Would it be possible to add a test for this to ensure that we do not accidentally run into the same situation again? Something like a simplified version of the snippet in #2504 with a very simple image in which you can easily assert based on specific pixel values if the image was properly sized or not.

Added test

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine and it properly fixes #2504
I have tested with the snippet provided in that issue.

Thank you also for adding a proper regression test. I only have minor comments regarding that test.

@arunjose696 arunjose696 force-pushed the arunjose696/drawImageNonAutoScalable branch 2 times, most recently from 15a9920 to 28d0e34 Compare September 25, 2025 08:35
The calculated image zoom for the source image should be the same as the GCzoom(100) when the drawable of GC is not scalable
Fixes: eclipse-platform#2504
@HeikoKlare HeikoKlare force-pushed the arunjose696/drawImageNonAutoScalable branch from 28d0e34 to d892d79 Compare September 25, 2025 09:04
@HeikoKlare HeikoKlare merged commit d5273ee into eclipse-platform:master Sep 25, 2025
15 of 17 checks passed
@HeikoKlare HeikoKlare deleted the arunjose696/drawImageNonAutoScalable branch September 25, 2025 09:22
@iloveeclipse
Copy link
Member

Caused regression in #2557

@arunjose696
Copy link
Contributor Author

arunjose696 commented Sep 29, 2025

Caused regression in #2557

This regression is in the test added in the same commit

I think the reason here would be e.gc.drawImage()'s draw request to the OS, might not have completed by the time gcCopy.copyArea() was called, in the test. This was a consideration which was thought of, to add readAndDispatch() call but could see there were no failures in the CI for linux when this PR was made so I decided to skip the call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants