-
Notifications
You must be signed in to change notification settings - Fork 7
[Siteplan] e2e testing #2126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Siteplan] e2e testing #2126
Conversation
This comment has been minimized.
This comment has been minimized.
Test Results131 tests ±0 131 ✅ ±0 31s ⏱️ -4s Results for commit 33fcd65. ± Comparison against base commit d276991. This pull request removes 9 and adds 9 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/license-check |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
.github/workflows/quality.yml
Outdated
| - name: Eslint | ||
| run: cd web/textviewer && npm run lint | ||
|
|
||
| test-siteplan: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariusheine i think, we should make own workflow for all testing, also swtbot and this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TruongQuangSB Yeah good idea. I will adjust the workflows
This comment has been minimized.
This comment has been minimized.
License summary❌ Not yet vetted dependencies:
Workflow run (with attached summary files): |
| workflows: ["Build SET"] | ||
| types: [completed] | ||
| branches: | ||
| - '*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariusheine Did you already test this Workflow on your fork ? I think this workflow should be triggered by "Build SET" workflow. When trigger by "Build SET" completed, then it can't take correct the artifact for test.
Otherweise should this Workflow only execute by main, normal PR and update package.json in siteplan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TruongQuangSB No I have not tested it by now. I wanted to trigger it only on completed because otherwise the SET build was not successful.
TruongQuangSB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
No description provided.