Skip to content

[5765] Add support for interpreted expressions in node styles #5920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
frouene wants to merge 13 commits into
base: cooldown
Choose a base branch
from
Open

[5765] Add support for interpreted expressions in node styles #5920

frouene wants to merge 13 commits into from

Conversation

@frouene
Copy link
Contributor

@frouene frouene commented Dec 4, 2025

Bug: #5765

Pull request template

General purpose

What is the main goal of this pull request?

  • Bug fixes
  • New features
  • Documentation
  • Cleanup
  • Tests
  • Build / releng

Project management

  • Has the pull request been added to the relevant project and milestone? (Only if you know that your work is part of a specific iteration such as the current one)
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, difficulty:, type:)
  • Have the relevant issues been added to the same project and milestone as the pull request?
  • Has the CHANGELOG.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc? (Including changes in the GraphQL API)
  • In case of a change with a visual impact, are there any screenshots in the CHANGELOG.adoc? For example in doc/screenshots/2022.5.0-my-new-feature.png

Architectural decision records (ADR)

  • Does the title of the commit contributing the ADR start with [doc]?
  • Are the ADRs mentioned in the relevant section of the CHANGELOG.adoc?

Dependencies

  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • Are the new dependencies justified in the CHANGELOG.adoc?

Frontend

This section is not relevant if your contribution does not come with changes to the frontend.

General purpose

  • Is the code properly tested? (Plain old JavaScript tests for business code and tests based on React Testing Library for the components)

Typing

We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).

  • Variables have a proper type
  • Functions’ arguments have a proper type
  • Functions’ return type are specified
  • Hooks are properly typed:
    • useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
    • useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
    • useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
    • useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
    • useState<STATE_TYPE>(…)
  • All components have a proper typing for their props
  • No useless optional chaining with ?. (if the GraphQL API specifies that a field cannot be null, do not treat it has potentially null for example)
  • Nullable values have a proper type (for example let diagram: Diagram | null = null;)

Backend

This section is not relevant if your contribution does not come with changes to the backend.

General purpose

  • Are all the event handlers tested?
  • Are the event processor tested?
  • Is the business code (services) tested?
  • Are diagram layout changes tested?

Architecture

  • Are data structure classes properly separated from behavioral classes?
  • Are all the relevant fields final?
  • Is any data structure mutable? If so, please write a comment indicating why
  • Are behavioral classes either stateless or side effect free?

Review

How to test this PR?

Please describe here the various use cases to test this pull request

  • Has the Kiwi TCMS test suite been updated with tests for this contribution?

sbegaudeau and others added 13 commits November 21, 2025 15:31
@sbegaudeau
[doc] Prepare the CHANGELOG for 2026.1.0
3de7fab 
Signed-off-by: Stéphane Bégaudeau <[email protected]>
@pcdavid @sbegaudeau
[releng] Switch to Spring Boot 3.5.8
ab442f8 
Signed-off-by: Pierre-Charles David <[email protected]>
@frouene @sbegaudeau
[releng] Bump elkjs to 0.11.0
a6fbf31 
Signed-off-by: Florian ROUËNÉ <[email protected]>
@mcharfadi @sbegaudeau
[5684] Remove the concept of palette from DiagramDescription
c8cea9d 
Bug: #5684
Signed-off-by: Michaël Charfadi <[email protected]>
@frouene
[5855] Prevent hidden edges from being considered for CrossFade Tunne…
0bba993 
…l detection

Bug: #5855
Signed-off-by: Florian ROUËNÉ <[email protected]>
@gdaniel @sbegaudeau
[doc] Add a shape on the configuration of workbench panels
14be32d 
Signed-off-by: Gwendal Daniel <[email protected]>
@gdaniel @sbegaudeau
[doc] Add an ADR to ensure index results contain enough information
23d8805 
Signed-off-by: Gwendal Daniel <[email protected]>
@sbegaudeau
[5887] Add additional pull request checks
460c670 
Bug: #5887
Signed-off-by: Stéphane Bégaudeau <[email protected]>
@pcdavid @sbegaudeau
[5832] Fix error when duplicating a project with representation opened
96d4a9c 
Bug: #5832
Signed-off-by: Pierre-Charles David <[email protected]>
@pcdavid @sbegaudeau
[5720] Fix a bug where searching would sometimes not reveal the eleme…
e3e7afa 
…nt in the Explorer

Bug: #5720
Signed-off-by: Pierre-Charles David <[email protected]>
@pcdavid @sbegaudeau
[doc] Add ADR for customizable model browser in reference widget
dae5239 
Signed-off-by: Pierre-Charles David <[email protected]>
@frouene @sbegaudeau
[5851] Add different arrange all elk options
fbfa177 
Bug: #5851
Signed-off-by: Cédric BRUN <[email protected]>
Signed-off-by: Florian ROUËNÉ <[email protected]>
@frouene
[5765] Add support for interpreted expressions in node styles
9ba7db9 
Bug: #5765
Signed-off-by: Florian ROUËNÉ <[email protected]>
@frouene frouene added this to the 2026.1.0 milestone Dec 4, 2025
frouene
frouene commented Dec 4, 2025
View reviewed changes
...ackend/sirius-components-view-diagram-customnodes/src/main/resources/model/customnodes.ecore
nsPrefix="customnodes">
<eClassifiers xsi:type="ecore:EClass" name="EllipseNodeStyleDescription" eSuperTypes="../../../../../sirius-components-view-diagram/src/main/resources/model/diagram.ecore#//NodeStyleDescription">
<eStructuralFeatures xsi:type="ecore:EReference" name="background" eType="ecore:EClass ../../../../../sirius-components-view/src/main/resources/model/view.ecore#//UserColor"/>
<eStructuralFeatures xsi:type="ecore:EAttribute" name="opacityExpression" eType="ecore:EDataType ../../../../../sirius-components-view/src/main/resources/model/view.ecore#//InterpretedExpression"/>
Copy link
Contributor Author

@frouene frouene Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to add the example to rectangularNode because all of its style fields are shared with other elements (e.g., borderNodeStyle, which is used for labels).

Copy link
Member

@sbegaudeau sbegaudeau Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why it's an issue? That was my point, introduce this capability and ensure that it would works for nodes, edges, etc. which is why I was in favor of something like font size which is not customized often but used pretty much everywhere.

It would be very odd to introduce a new feature (control manually the opacity of a node) just for one specific custom node type on top of that.

Copy link
Contributor Author

@frouene frouene Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it is already possible today to interpret font size, at least programmatically, (in the view DSL it's not an expression).
Only style edges and node styles are not, and there is no notion of font.
The only style properties are colors, line style, border size and border radius.
I could change the border size and border radius to be an expression.

...b-application/src/main/java/org/eclipse/sirius/web/application/diagram/EllipseNodeStyle.java

private ILayoutStrategy childrenLayoutStrategy;

private String opacity;
Copy link
Contributor Author

@frouene frouene Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine we would want to be able to overload this value using the appearance palette?
Even though it is an interpreted value.

@frouene frouene linked an issue Dec 4, 2025 that may be closed by this pull request
Make it possible to have interpreted fields in elements style descriptions #5765
Open
1 task
@sbegaudeau sbegaudeau force-pushed the cooldown branch 3 times, most recently from 39f7a88 to df23d88 Compare December 4, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbegaudeau sbegaudeau sbegaudeau left review comments

Assignees

@sbegaudeau sbegaudeau

Labels

pr: to review soon priority: low

Projects

None yet

Milestone

2026.1.0

Development

Successfully merging this pull request may close these issues.

Make it possible to have interpreted fields in elements style descriptions

6 participants

@frouene @sbegaudeau @pcdavid @mcharfadi @gdaniel