Skip to content

Conversation

@Friz-zy
Copy link

@Friz-zy Friz-zy commented Jun 14, 2025

What it does

Adding docker support for theia browser build:

  • Dockerfile for build and distribute
  • dockerignore for using in docker build
  • docker-compose.yml for local development and usage
  • github ci pipeline for building docker images for new git tags and store it in the github docker registry (packages section)

How to test

  1. docker compose build
  2. docker compose up -d
    Open browser and navigate to http://localhost:3000
    Verify Theia IDE loads correctly in the browser.
  3. For CI pipeline testing: git tag test && git push --tags.
    Check GitHub Actions for successful docker image build and push to registry

Follow-ups

None

Breaking changes

None

Attribution

None

Review checklist

Reminder for reviewers

@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Jun 14, 2025
@msujew
Copy link
Member

msujew commented Jun 15, 2025

Hey @Friz-zy, thank you for the contribution.

However, this is the Theia framework repo, and as such, does not distribute an application. The Theia IDE application has its own repo (dockerfile already included). So I'm not sure whether there is any need for a docker image build pipeline in this repo. @tsmaeder what do you think?

Aside from that, it seems like you haven't signed the Eclipse Contributor Agreement (ECA). Please sign the agreement with the same email that was used to create the commit. Otherwise, we are not allowed to merge the change.

@Friz-zy
Copy link
Author

Friz-zy commented Jun 15, 2025

Hi @msujew :)

Sorry, I didn't see the neighboring repository specifically for IDE. If you want, I can disable or delete the GitHub CI pipeline so you can use Dockerfile & Compose just for development.

upd: I created account for eclipse.org and signed agreement, but site doesn't allow dots in email address so it doesn't match my github email xD

@JonasHelming
Copy link
Contributor

@sgraband @jfaltermeier

@tsmaeder
Copy link
Member

One of the things we learn when building in github actions is whether the framework builds on various combinations of OS and node versions. As I understand, this PR aims to do away with this, which is a net negative, IMO.
As @msujew mentioned, the intent of this repo is not to produce a ready-to-run product, that is done over at the theia-ide repo. @Friz-zy maybe you could explain why you want to make these changes? I'm kinda missing the benefit as it stands.

@msujew
Copy link
Member

msujew commented Jun 16, 2025

upd: I created account for eclipse.org and signed agreement, but site doesn't allow dots in email address so it doesn't match my github email

I'm using a dot in my Eclipse account email address, so unless they changed it, it should work. Unfortunately, we're not able to merge unless the ECA check passes (as indicated by the Required info label in the workflows field).

@ndoschek
Copy link
Contributor

ndoschek commented Nov 3, 2025

As this has been stale for a while, I'm closing for now, but feel free to reopen in case you disagree, thanks!

@ndoschek ndoschek closed this Nov 3, 2025
@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Done in PR Backlog Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants