-
Notifications
You must be signed in to change notification settings - Fork 61
[Model Update] PCF:9.0.0 #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BirgitBoss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improve release notes
|
I included all requested changes. |
AntjeFischer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes reviewed carefully, anything there as expected.
stanfaldin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as from the off-line discussions and finalisations with @AntjeFischer and @jSchuetz88 the PR is hereby approved
stephanbcbauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as discussed with @jSchuetz88
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerIdandDismantlerNameuse an EntityDismantlerwith the propertiesnameandidor use a URN likeio.catenax.dismantler:0.0.1)preferredNameanddescriptionare not the samepreferredNameshould be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)