Queue metrics for single address connection pool #1454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient metrics SPI. This updates the implementation to actually log queue metrics to the client SPI when the pool uses a fixed connect options (the reason is that the client metrics SPI is coupled to the socket address of the client and most likely this should be changed in Vert.x 5)
vietj
force-pushed
the
pool-queue-metrics-4.x
branch
from
9f0fca4 to
2b09d83
Compare
vietj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pool implementation does not actually log queue metrics to the client metrics SPI.
This updates the implementation to actually log queue metrics to the client SPI when the pool uses a fixed connect options (the reason is that the client metrics SPI is coupled to the socket address of the client and most likely this should be changed in Vert.x 5)