Re-enable MSSQL in CI (4.x) #1459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iner issue" This reverts commit 2b09d83.
Failures could be seen both on the developer machine and on CI. Microsoft has changed the path to the sqlcmd utility in the latest releases of the image. Besides, they have made connecting on an encrypted connection with sqlcmd mandatory by default. Therefore, we must configure the utility to make this optional (-No). Also, when now certificate are always validated but test servers use self-signed certificates. For this reason, the utility must not try to validate the server certificate (-C). Lastly, unlike the mcr.microsoft.com/mssql/server image, the mcr.microsoft.com/mssql-tools image has not been updated. So the latest image release still uses the old sqlcmd utility path and options. To avoid discrepancies in our setup, we'll use the mcr.microsoft.com/mssql/server image everywhere from now on. We don't care too much about the size, because we need this image to run the server anyway. Signed-off-by: Thomas Segismont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1457