Make try_recv throw on closed channel #629
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
PR missing one of the required labels: {'enhancement', 'breaking-change', 'dependencies', 'internal', 'bug', 'ci', 'documentation', 'api-sync', 'new feature'} |
Contributor
|
PR missing one of the required labels: {'breaking-change', 'internal', 'api-sync', 'dependencies', 'enhancement', 'documentation', 'new feature', 'bug', 'ci'} |
DenisBiryukov91
force-pushed
the
try-receive-throw-on-closed-channel
branch
from
f1c5122 to
1468453
Compare
wyfo
suggested changes
Nov 7, 2025
Contributor
wyfo
left a comment
wyfo
left a comment
There was a problem hiding this comment.
Overall, I think it's a bug fix, but it's also a breaking change, so we should balance both to decide if we merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make try_recv throw on closed channel