fix how we handle empty values

[kchobantonov]

fix how we handle empty values when not in dynamic context (e.g. addtionalProperties case)

[netlify]

✅ Deploy Preview for jsonforms-examples ready!

Name	Link
🔨 Latest commit	44440e9
🔍 Latest deploy log	https://app.netlify.com/projects/jsonforms-examples/deploys/690e01018f63cd00080dd8e5
😎 Deploy Preview	https://deploy-preview-2481--jsonforms-examples.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[kchobantonov]

@sdirix please review - when we update the handling of empty values it looks like deleting (not using the x - clear ) was setting the value to empty string rather to remove the property when we are not under dynamic context (e.g. additionalProperties where we need to preserve the key)

[sdirix]

Changes make sense to me in general. However there are a number of "non-changes" in the PR. Also I just noticed that we might have an overall enum issue.

[kchobantonov]

@sdirix it is ready to be reviewed again - check my comments regarding the null value cases.

[lucas-koehler]

Hi @kchobantonov , thanks for the updates. The code looks pretty good to me. However, it seems to break something with the enum value display. See the video below. On master the same text is shown in the dropdown and the enum renderer's text field. Please have a look

jf-vuetify-enums.webm

[kchobantonov]

Hi @kchobantonov , thanks for the updates. The code looks pretty good to me. However, it seems to break something with the enum value display. See the video below. On master the same text is shown in the dropdown and the enum renderer's text field. Please have a look

jf-vuetify-enums.webm

looks like adding :return-object="true" breaks how the component shows the value and the reason why we have added that was to be able to distinguish when the value was cleared vs when the actual enum value is null since if we do not use the item but the value of the item in the original case we can't be sure if the value null represents an item with value null vs when the item is not selected. Will look more into that but at this point looks like some strange behavior with the vuetify component when return-object is used.

[kchobantonov]

will revert the return-object change and will wait until this issue with vuetify vuetifyjs/vuetify#22126 is fixed to change the comparison for the null value to perhaps undefined

[kchobantonov]

@lucas-koehler thanks for the report - please review again