Fix: replace_last filter bug with duplicate substrings
#176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `replace_last` filter was failing in some cases, for example when trying to replace the last occurence of a string that has duplicates. I've fixed this issue by using a more robust implementation of the `replace_last` filter, using `String.reverse/1`. I also added unit tests for the `replace_last` filter, which were missing. Additionally, I've made the `replace_last` filter stricter about the number of arguments, to match the behavior of the ruby liquid gem.
The `replace_last` filter was failing in some cases, for example when trying to replace the last occurence of a string that has duplicates. This commit fixes this issue by using a more robust and efficient implementation of the `replace_last` filter. This commit also adds unit tests for the `replace_last` filter to the doctests, as they were missing. This commit also makes the `replace_last` filter stricter about the number of arguments, to match the behavior of the ruby liquid gem.
edgurgel
approved these changes
Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
replace_lastfilter that caused it to fail when the string to be replaced has duplicates. The implementation has been updated to use a more robust approach withString.reverse/1, and new unit tests have been added to cover the failing cases and improve test coverage.