Feat/pedago configurable oauth2 expiration #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read a new conf value named 'oauth2-token-expiration-time-seconds' with a default value of 3600
nabil-mansouri
approved these changes
Apr 15, 2025
jenkinsEdificePublic
force-pushed
the
develop-pedago
branch
from
5487971 to
d34cc8f
Compare
nabil-mansouri
force-pushed
the
develop-pedago
branch
from
9dd1065 to
224be6c
Compare
nabil-mansouri
force-pushed
the
develop-pedago
branch
from
23085a5 to
ea41c94
Compare
jenkinsEdificePublic
force-pushed
the
develop-pedago
branch
from
2d32fd3 to
63e02a4
Compare
nabil-mansouri
force-pushed
the
develop-pedago
branch
from
3de78a2 to
98d5968
Compare
jenkinsEdificePublic
force-pushed
the
develop-pedago
branch
2 times, most recently
from
8247ff8 to
601e99c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 3600 second expiration time of a new oAuth2 token is now configurable with the key 'oauth2-token-expiration-time-seconds'. The value si 3600 by default to make no regression if the conf value is not present.
This commit is for debug purpose on clients that manages oAuth2 tokens.
Fixes
Type of change
Which packages changed?
Please check the name of the package you changed
Tests
Without define a value in conf for 'oauth2-token-expiration-time-seconds', no changes are expected.
When this value is defined, the 'expiresIn' value in response for
POST /auth/oauth2/tokenhas to be equal to the configured value.Reminder
Security flaws
Performance impacts (think bulk !)
Unit tests were replayed
Unit tests were added and/or changed
I have updated the reminder for the version including my modifications
All done ! 😃