-
Notifications
You must be signed in to change notification settings - Fork 10
Fix coco 4672 template processor race condition #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vbillard91
wants to merge
11
commits into
develop-b2school
Choose a base branch
from
fix-COCO-4672-template-processor-race-condition
base: develop-b2school
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix coco 4672 template processor race condition #907
vbillard91
wants to merge
11
commits into
develop-b2school
from
fix-COCO-4672-template-processor-race-condition
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34150e8 to
dd4270b
Compare
juniorode
requested changes
Oct 13, 2025
696f3ad to
e91bc1b
Compare
367d79a to
ae64026
Compare
ae64026 to
05d6b22
Compare
|
2728bc2 to
e8ac3d6
Compare
7bc8194 to
b632e18
Compare
669ca6b to
a92764b
Compare
0c1f971 to
49599ca
Compare
49599ca to
0af22e7
Compare
139bd28 to
173b936
Compare
b4aadd7 to
8ad352f
Compare
aff45b8 to
2fb7574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
Les TemplateProcessor largement utilisés dans le code ne sont pas thread safe au niveau des Lambda. On pourrait donc avoir des mélanges entre les paramètres de plusieurs utilisateurs lors de la génération de mail / notification / carte timeline etc… entre la langue, l’host, le thème ou le domaine => refactoring partiel pour corriger le problème. Cette PR n'est pas exhaustive, car cela fait trop de changement.
Fixes
https://edifice-community.atlassian.net/browse/COCO-4672
Type of change
Please check options that are relevant.
Which packages changed?
Please check the name of the package you changed
Tests
Reminder
Security flaws
Performance impacts (think bulk !)
Unit tests were replayed
Unit tests were added and/or changed
I have updated the reminder for the version including my modifications
All done ! 😃