feat: geant4 +vecgeom ^vecgeom +cuda when building cuda
#49
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
force-pushed
the
geant4-vecgeom-cuda
branch
from
4723ea6 to
525cbab
Compare
wdconinc
force-pushed
the
geant4-vecgeom-cuda
branch
from
525cbab to
bf1ae00
Compare
| vecgeom: | ||
| require: | ||
| - '@1.2.11' | ||
| - cxxstd=20 +gdml ~geant4 +root |
There was a problem hiding this comment.
The vecgeom requirement includes ~geant4 which disables geant4 integration in vecgeom. However, this PR adds geant4 +vecgeom to make geant4 use vecgeom. These settings may conflict depending on how Spack resolves the dependency. Consider whether the ~geant4 variant on vecgeom should be changed to allow geant4 integration, or verify that this configuration is intentional and will work as expected with geant4's new +vecgeom variant.
Suggested change
| - cxxstd=20 +gdml ~geant4 +root | |
| - cxxstd=20 +gdml +root |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR aims to ensure that we use geant4 and vecgeom with cuda support throughout the cuda images.
What kind of change does this PR introduce?