Fixing applies_to tags #4465
Fixing applies_to tags #4465
Conversation
part of #4117 Replacing all the tags on the page with stack as it applies to all deployments. The tab titles were also wrong, they should be split as UI vs API instructions.
Vale Linting ResultsSummary: 2 suggestions found 💡 Suggestions (2)
|
| @@ -1,4 +1,4 @@ | |||
| :::{admonition} Simplify monitoring with AutoOps | |||
| :applies_to: { ess:, ece:, eck:, self:, "serverless": "ga" } | |||
| :applies_to: { "stack": "ga", "serverless": "ga" } | |||
There was a problem hiding this comment.
we should check with @wajihaparvez before we make this change (I think ultimately the fix might be no tags at all, so it just inherits the page context, given that autoops is now available everywhere)
There was a problem hiding this comment.
That's a good point! I're removed this change from this PR and opened #4470 instead, so that Wajiha can have a look when she's back online.
shainaraskas
left a comment
shainaraskas
left a comment
There was a problem hiding this comment.
I think add-tier needs a little more work to make the action clear (it was clearer in the old organization), and I added one suggestion for the corruption page
|
|
||
| ::::::{tab-item} API | ||
| In order to get the shards assigned you can add more nodes to your {{es}} cluster and assign the index’s target tier [node role](../../manage-data/lifecycle/index-lifecycle-management/migrate-index-allocation-filters-to-node-roles.md#assign-data-tier) to the new nodes. | ||
| To get the shards assigned, you can add more nodes to your {{es}} cluster and assign the index’s target tier [node role](../../manage-data/lifecycle/index-lifecycle-management/migrate-index-allocation-filters-to-node-roles.md#assign-data-tier) to the new nodes. |
There was a problem hiding this comment.
this step varies between deployment types (the tiers are set differently in ECE / ECH)
self/eck: https://www.elastic.co/docs/deploy-manage/distributed-architecture/clusters-nodes-shards/node-roles#change-node-role / https://www.elastic.co/docs/manage-data/lifecycle/data-tiers#configure-data-tiers-on-premise (I wouldn't use the migration topic currently linked - bad practice to bury evergreen info in migration topics that might be removed)
ECE/ECH matches steps 5-8 that you removed
https://www.elastic.co/docs/manage-data/lifecycle/data-tiers#configure-data-tiers-cloud
There was a problem hiding this comment.
I've update the link as per your suggestion and added the steps back in.
There was a problem hiding this comment.
this tutorial is no longer really doing anything / it's unclear what the "action" is. the order needs to be:
- determine the desired tier for an index
- make sure there's room in the tier
There was a problem hiding this comment.
I've fixed this in a new commit, let me know what you think.
There was a problem hiding this comment.
we don't want to be in a situation where we only have ECH and self-managed instructions, when the page is supposed to apply to ECH/ECE/ECK/self-managed (self-managed in docs always meaning a fully, manually self-managed cluster). this organization is close, but ECE follows the ECH path and ECK has some extra requirements not documented at this link.
IMO the easiest way to fix this is to break it up into two sections:
step 1: determine target tier
step 2: resize (with pathways for each deployment type)
the info customers need here is similar to this note:
https://github.com/elastic/docs-content/pull/4475/files#diff-2ffc185dff3a45f8a151a9cc15e01e15f80e04641d514bda1a53996490a46e63R16
I also provided some info here: #4465 (comment)
if you prefer, you can take the changes to this file out of this PR and we can handle it separately
There was a problem hiding this comment.
Okay, this makes more sense. Please let me know if this looks better now: https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/4465/troubleshoot/elasticsearch/add-tier
Summary
part of #4117
Replacing all the tags on the page with stack as it applies to all deployments. The tab titles were also wrong, they should be split as UI vs API instructions.
Generative AI disclosure