Marking file types in the test binary corpus #631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliben
reviewed
Dec 1, 2025
Owner
eliben
left a comment
eliben
left a comment
There was a problem hiding this comment.
Thanks, I like this idea overall. Just one question
eliben
approved these changes
Dec 1, 2025
Owner
|
My comment: "Hmm, I think the try...else masks the assertions. I'll work on a fix" We also have |
eliben
added a commit
that referenced
this pull request
Dec 1, 2025
Also remove try...else which was masking failures, and add a context manager for the opened files (otherwise we get warnings when running locally) Re #631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a half upheld convention in the test file corpus that shared object files are marked with .so, object files are marked with .o. This makes sure the convention is being followed.
Core dump files, of which we have a handful, are not marked in the name - not sure how.
This will make things marginally easier for #564 and #586.