Skip to content

Partially fix issues with #450, Mint Reduce Reponses. #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Partially fix issues with #450, Mint Reduce Reponses. #510

wants to merge 4 commits into from

Conversation

@crova
Copy link

@crova crova commented Dec 22, 2021 •
edited
Loading

This PR handles {:push_promise, request_ref(), promised_request_ref :: request_ref(), headers()}.
And also {:error, ref, error} that seems to be missing as well.

Let me know if I can improve this @teamon .

@teamon
Copy link
Member

teamon commented May 8, 2022

Awesome!

@crova Can we write some tests for this?

@teamon teamon linked an issue May 8, 2022 that may be closed by this pull request
Mint reduce_responses doesn't handle all possible responses #450
Open
@teamon teamon added mint Issues related to mint adapter fix 🧯 labels May 8, 2022
@crova
Copy link
Author

crova commented May 9, 2022

Sure @teamon , I'll try to get that done this week.

@yordis
Copy link
Member

yordis commented May 30, 2022

@crova any updates on this one?

@crova
Copy link
Author

crova commented May 31, 2022 •
edited
Loading

Sorry folks, I lost track of this one.
I'll get back to this ASAP.

Edit: Just FYI, I've started looking at adding tests to this PR. It's been a long time since I touch this so I'll need to do some catching up to remember where I left this one.
Sorry it's taking too long but I've been busy lately.
I'll try to submit something as quick as I can.

Cheers.

@crova
Copy link
Author

crova commented Jun 21, 2022

Hey folks, how is it going?
I might need some help on how to properly test this.
Being a private function I'm having trouble to find a clean way to validate the changes.
Anyone with more familiarity/knowledge has any suggestions on how to tackle this?

Cheers.

@yordis yordis force-pushed the master branch 6 times, most recently from 2bca420 to fe7207c Compare October 24, 2024 16:11
@yordis
Copy link
Member

yordis commented Aug 28, 2025

closing in favor of #803

@yordis yordis closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@crova crova

Labels

fix 🧯 mint Issues related to mint adapter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mint reduce_responses doesn't handle all possible responses

3 participants

@crova @teamon @yordis