Skip to content

Escape chars for elixir v1.19 compat #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Escape chars for elixir v1.19 compat #620

wants to merge 1 commit into from

Conversation

@naserca
Copy link

@naserca naserca commented Sep 29, 2025 •
edited
Loading

In the v1.19 branch (specifically) of elixir-lang, these chars cause a SyntaxError:

== Compilation error in file lib/faker/string.ex ==
** (SyntaxError) invalid syntax found on lib/faker/string.ex:217:16:
     error: invalid line break character in string: \u2029. If you want to use such character, use it in its escaped \u2029 form instead
     │
 217 │     "\u2029test
",
     │                ^
     │
     └─ lib/faker/string.ex:217:16
    (elixir 1.19.0-rc.0) lib/kernel/parallel_compiler.ex:480: anonymous fn/5 in Kernel.ParallelCompiler.spawn_workers/8

This PR escapes them without other changes.

@naserca naserca mentioned this pull request Sep 29, 2025
Open
seantanly added a commit to yojee/faker that referenced this pull request Oct 20, 2025
@seantanly
fix: based on naserca@195752b
fb4247d 
- elixirs#620
zekedou added a commit to ever-forge/fake that referenced this pull request Oct 22, 2025
@zekedou
feat: escape chars for elixir v1.19 compat
d1df1c6 
Patch elixirs/faker#620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@naserca