Skip to content

Conversation

@hauthorn
Copy link

@hauthorn hauthorn commented Oct 8, 2025

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used the project.
  • I have used the project briefly.
  • I have used the project extensively, but have not contributed previously.
  • I am an active contributor to the project.

We've been using this package for a long while, and when upgrading to PHP 8.4, we noticed output like this when running tests:

PHP Deprecated:  EllipseSynergie\ApiResponse\AbstractResponse::withCollection(): Implicitly marking parameter $cursor as nullable is deprecated, the explicit nullable type must be used instead in [PROJECT_FOLDER]/vendor/ellipsesynergie/api-response/src/AbstractResponse.php on line 131
PHP Deprecated:  EllipseSynergie\ApiResponse\Contracts\Response::withItem(): Implicitly marking parameter $resourceKey as nullable is deprecated, the explicit nullable type must be used instead in [PROJECT_FOLDER]/vendor/ellipsesynergie/api-response/src/Contracts/Response.php on line 62

This PR should fix that. Marking paramaters as nullable is supported in PHP 8.1.

It is deprecated in php 8.4, and triggers PHP notices/warnings.
@hauthorn hauthorn changed the title Removed Implicit marking parameter as nullable [FIX]Removed Implicit marking parameter as nullable Oct 8, 2025
@hauthorn
Copy link
Author

hauthorn commented Oct 8, 2025

@maximebeaudoin - Let me know if this is at all interesting to you, and if there's something else I can do to make the review easier for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant