-
-
Notifications
You must be signed in to change notification settings - Fork 517
Cleaning up references to barrel file "Ember.*" naming pattern #2184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| @@ -1,72 +0,0 @@ | |||
| <div class="cta"> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prototype extensions were removed at 6.0, so this whole file can go.
|
|
||
| If you're using the [ember-cli-app-version](https://github.com/embersherpa/ember-cli-app-version) addon, your application's name and version will be added to the list automatically. | ||
|
|
||
| Libraries only appear in this list if they manually register themselves with Ember. So we don't recommend relying on this tab anymore, it's better to use any tool that's designed to analyze your package.json instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to reduce the scope of this page and caution against relying on it, rather than just port the registration code to use @ember/-internals/metal, which is the only remaining way to do library registration. A separate RFC that improves inspector support could be responsible for making this tab more useful (by actually guaranteeing that it matches your package.json dependencies).
| interface Array<T> extends Ember.ArrayPrototypeExtensions<T> {} | ||
| interface Function extends Ember.FunctionPrototypeExtensions {} | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prototype extensions are gone.
Cleaning up places where we use
Ember.*to name things, since that goes away with the deprecation (in ember-source 6.5) and removal (at ember-source 7.0) of the barrel file.