Skip to content

Conversation

@codeshaunted
Copy link

@codeshaunted codeshaunted commented Jan 12, 2026

Add sizes and enable implicit addend support for R_386_GOT32, R_386_PLT32, R_386_GOTOFF, and R_386_GOTPC.

This passes all pre-commit except for cargo fmt. It was reformatting nearly all files for some reason so I disabled it locally. Let me know if you know how to fix that. Fixed!

@LagoLunatic
Copy link
Collaborator

This passes all pre-commit except for cargo fmt. It was reformatting nearly all files for some reason so I disabled it locally. Let me know if you know how to fix that.

cargo +nightly fmt

@tomsons26
Copy link
Contributor

tomsons26 commented Jan 12, 2026

if R_386_PC32 is there and R_386_16 is being added, then i guess R_386_PC16 should too?

@codeshaunted
Copy link
Author

codeshaunted commented Jan 12, 2026

if R_386_PC32 is there and R_386_16 is being added, then i guess R_386_PC16 should too?

The size for R_386_16 was actually already there for some reason, just without implicit addend support. I can add it later today if that would be desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants