test(ses): repro 2941 errorTrapping bugs #2944
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-test-2941-error-traps
branch
from
37d8080 to
cdca569
Compare
naugtur
reviewed
Sep 3, 2025
erights
force-pushed
the
markm-test-2941-error-traps
branch
from
cdca569 to
fbb0ed1
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds baseline reproduction test cases for issue #2941, which appears to involve errorTrapping bugs in the SES (Secure ECMAScript) implementation. The PR creates a comprehensive test suite demonstrating different error handling behaviors across various configurations.
- Creates demo files to reproduce error trapping behaviors across different SES configurations
- Documents expected vs actual behavior for multiline error messages and error causes
- Sets up test cases for both Node.js and browser environments to establish baseline behavior
Reviewed Changes
Copilot reviewed 14 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test3/*.demo.js | Node.js demo files testing error cause handling with different errorTrapping configurations |
| test3/README.md | Documents duplicated file paths in error cause output when using 'platform' errorTrapping |
| test2/*.demo.js | Node.js demo files testing multiline error message handling |
| test2/README.md | Documents multiline error message duplication issue with 'platform' errorTrapping |
| test1/*.html | Browser-based HTML test files for different errorTrapping configurations |
| test1/test.notjs | Invalid syntax test file to trigger parsing errors in browsers |
| test1/README.md | Documents browser behavior testing approach with placeholder content |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
erights
force-pushed
the
markm-test-2941-error-traps
branch
3 times, most recently
from
d3972dd to
766a1d8
Compare
erights
force-pushed
the
markm-test-2941-error-traps
branch
2 times, most recently
from
bdf841f to
7e11152
Compare
|
PTAL |
erights
force-pushed
the
markm-test-2941-error-traps
branch
from
9af8047 to
e5da7f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a baseline repro, so future PRs that fix these bugs can illustrate what's different.
Closes: #XXXX
Refs: #2941 #2945
Description
Just a baseline repro of #2941 , so a future PR (such as #2945) that fix this bug can illustrate what's different.
Security Considerations
Adds only test cases without any changes to the system being tested, so none.
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
The point. The added test cases are a baseline repro to be fixed in an upcoming PR #2945
Compatibility Considerations
none
Upgrade Considerations
none