Skip to content

Conversation

@BenIVRE
Copy link

@BenIVRE BenIVRE commented Mar 26, 2024

Also can convert Text to RTLTMP.

Taken from a PR from the base repo: pnarimani#114

Also can convert Text to RTLTMP
@BenIVRE BenIVRE requested a review from a team March 26, 2024 17:34
@BenIVRE BenIVRE enabled auto-merge (squash) March 26, 2024 17:46
}

/// <summary>
/// Unfortunately I'm not sure how to do GUID swapping, so references to the text component will break, but at least it should make the transition much safer and quicker

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this asset handled the conversion to TMPro without losing references. Breaking existing references is not an option, there are thousands.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not what this asset does. We've already handled that in https://github.com/engage-xr/Engage_Main/pull/2004

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do raise a valid point though, if we go from TMP -> RTLTMP we would still potentially lose some references.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant references in other components, #2004 only handled references in code, but not from other non-code components.

@BenIVRE BenIVRE disabled auto-merge March 26, 2024 17:57
@BenIVRE
Copy link
Author

BenIVRE commented Mar 28, 2024

Closing this as we can handle it from the New UI Widgets converter by changing the type it goes to to be RTLTMPro

@BenIVRE BenIVRE closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants