-
Notifications
You must be signed in to change notification settings - Fork 410
Fix missing DeepSpeedConfig for deepspeed v0.9.1 #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I am still geting this issue |
Could you give more information about what you tried to do and at what point you encounter this issue? Because for me this is working fine with the |
|
I just gitclone the repo and try to run it |
|
data_dirs: [data/test] model: ar-quarter |
|
|
yes when i ran "python -m vall_e.train yaml=config/test/ar.yml" i encounterd the issue |
|
I saw your PR 92 but i am not getting where to put the code snippet |
|
|
this is the new error i am getting as " AttributeError: 'PosixPath' object has no attribute 'log_dir'" |
|
I think a easier solution would be doing deepspeed==0.8.3 |
|
Please reopen this PR. It's only a matter of time until we need to update the code to support a version of DeepSpeed > 0.8.3. |
|
With DeepSpeed 0.9.4 I get this error: It gets past these errors when specifying the following env vars: DeepSpeed needs to be hacked to be able to get past deepspeedai/DeepSpeed#826: |
@kgasenzer Hi, as you suggested, but got errors as bleows, could you help with this? thanks. deepspeed==0.15.0 /torch/distributed/distributed_c10d.py:4807: UserWarning: No device id is provided via |
Following the comment in https://github.com/microsoft/DeepSpeed/issues/3309 and discussions in #87 and #81 I added a fix for the missing
config_classintrainer.Engineby adding snippets from deepspeed/init.py.deepspeed.initializedoes.config_classasdeepspeed.runtime.config.DeepSpeedConfiginstanceThis fixes the problem in #87 as well as in #81.
This is only necessary if you want to use deepspeed>=0.9.1.