-
Notifications
You must be signed in to change notification settings - Fork 333
Build electron package on Linux with Bazel #14181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is needed on Windows
bbacd4f to
41f4fee
Compare
4607a47 to
c416d5a
Compare
32c5b7a to
0bf265f
Compare
|
Application is broken at the moment because of recent ydoc changes, investigating. |
|
Ydoc issue fixed |
|
I consider this PR ready to merge. It has fewer features than we planned initially, but:
@Frizi, please review the code. Most comments will likely be extracted to the TODO list and addressed separately. The current TODO list is available at #12860 |
|
Checked Mac + Linux builds locally, everything is working. |
Akirathan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes from the engine perspective are OK
Pull Request Description
As of ef55bcc:
Linux app image build is working, with some differences:
datadirectories in projects, e.g. Examples are not available.Otherwise, it should be a perfectly working linux build of Enso.
Mac build works, but only unpacked (dmg image packaging is not available yet)
Windows build does not work.
Building the application
Don’t forget to
pnpm installfirst!Application can be build in two modes:
pnpm exec bazel build //app/electron-client:dist— usesproduction.env file, versions info reported from inside the app can be incorrect. This is considered a legacy mode, and eventually we will transition out of it (with more sane defaults).pnpm exec bazel build --config=release //app/electron-client:dist— uses .env file that matches theNODE_ENVenvironment variable. The build should have correct version info in GUI. This is the inteded way of building the package.Built application is available in
bazel-bin/app/electron-client/ide-dist.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.