Remove git-clean subcommand of Rust build script #14213
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Removes
./run git-clean. You can usepnpm run git-clean [--verbose] [--clean-bazel]instead. It does require neither pnpm install nor Rust script compilation.Ideally, we wouldn’t clean Bazel at all times, but for simplicity, I preserved legacy behavior.
JVM tests job now always does a clean build, but I removed invocation of
git-cleanfrom./run backend test jvm. It solves the issue with cleaning the Rust binary on Windows while it is being used. In the future, we won’t have this problem anyway. Always cleaning in JVM tests job is required as per @Akirathan.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.