Rewriting ir.Module in Java
#14217
Merged
Rewriting ir.Module in Java
#14217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
requested review from
4e6,
Akirathan and
hubertp
as code owners
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
commented
Oct 29, 2025
| - [Usability](#usability) | ||
|
|
||
| <!-- /MarkdownTOC --> | ||
| - [Taming the Merge Operator](https://www.cambridge.org/core/journals/journal-of-functional-programming/article/taming-the-merge-operator/B8A3A5D16B7AB175D44DB6F980450863) |
There was a problem hiding this comment.
- This is an unrelated change.
- Link provided by @radeusgd
- the paper and especially the references it provides look interesting
Akirathan
approved these changes
Oct 29, 2025
...time-integration-tests/src/test/scala/org/enso/compiler/test/pass/resolve/PatternsTest.scala
Show resolved
Hide resolved
|
|
||
| public UUID id() { | ||
| return id; | ||
| // TBD: this method should return null when there is no ID |
There was a problem hiding this comment.
Making id private field in the generated super class seems like a good idea. The only usage of this id() method is in UnreachableMatchBranches and seems rather obscure. If we ever want to introduce some method like IR.hasID, we can do so in the future. If tests pass, I am OK with this change. I am a big fan of making stuff private.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #14086
Part of #14115
Pull Request Description
Rewrites the IR element at root of every module parse tree into Java.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,