Conversation
It skips if h5py isn't available OR if it is available but doesn't support parallel operations.
Contributor
Author
|
Hm. It seems to reliably hang on Travis. |
Contributor
|
Looks like it's hanging at the parallel test part -- any idea why? |
Contributor
Author
|
Moving to 0.7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I add a function
import_parallel_h5pytotesting.pythat tries to import a parallel-enabled h5py, and if one isn't available, it raisesunittest.SkipTest. This replaces most of our uses ofimport_or_skip(but not all) and callsimport_or_skipunder the hood.Unfortunately, @kwmsmith, it seems to make our paralleltests hang in my testing environment that actually has a parallel build of h5py. It skips tests correctly when there is no h5py or when there is a serial h5py installed.
Not ready for merge.