Open
Conversation
I was reading through this in detail in order to design a PyTrilinos adaptor, and found some changes I wanted to make. One question: a 'dim_data' tuple of length greater than one, where one or more of the dimension dictionaries has a 'dist_type' of 'u' would represent a structured array of unstructured dimensions. I am not aware of any uses cases for this configuration. Are you supporting it? I would be OK with a constraint that if 'dist_type' == 'u', then len(dim_data) = 1 must be true.
Contributor
|
We do have usecases for arrays with a mixture of unstructured and structured dimensions. And down the road, we may want to allow individual dimensions to be unstructured for use with fancy indexing in a specific dimension. Why can't PyTrilinos's adapator raise an exception if it gets a distributed array it can't handle? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was reading through this in detail in order to design a PyTrilinos adaptor, and found some changes I wanted to make.
One question: a 'dim_data' tuple of length greater than one, where one or more of the dimension dictionaries has a 'dist_type' of 'u' would represent a structured array of unstructured dimensions. I am not aware of any uses cases for this configuration. Are you supporting it? I would be OK with a constraint that if 'dist_type' == 'u', then len(dim_data) = 1 must be true.