test: add rollback regression test, fix in_tempdir constructors #3206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a regression test for rollback to batch.
The issue is triggered when the rollback is performed:
H >= 10,target_rollback_batch_idx > 0.The minimal non-empty proposal that triggers the regression contains 3 batches of 1 transaction each, where the rollback is performed to batch 1 (counting from 0 ofc).
Ultimately the non-empty proposal fixture is supposed to be randomized but for the time being I'm overriding the params mentioned above.
BTW empty proposals don't work correctly because the empty block that stems from the empty proposal has no way of figuring out the correct timestamp so every now and then an empty proposal causes a non-ascending timestamp value.