Improvements to starknet_simulateTransactions tests
#3211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sactions` - Instead of manually serializing a part of the method output and comparing that against fixtures, serialize and compare the entire output. - This ensures that the serialization starts at the top level and that no per-version logic is skipped. - Update test fixtures to match the new serialization strategy.
- Convert Rust type fixtures into JSON files that are loaded and compared against. - Having both the method output and the fixture as a Rust type that get serialized and compared means that it will be impossible to detect any errors in the serialization logic (which is now more complex due to the addition of `SimulationFlag::ReturnInitialReads`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starknet_simulateTransactions.SimulationFlag::ReturnInitialReads).