Example no-site flag for subinterpreters module#34
Open
tonybaloney wants to merge 3 commits intoericsnowcurrently:per-interpreter-gil-newfrom
Open
Example no-site flag for subinterpreters module#34tonybaloney wants to merge 3 commits intoericsnowcurrently:per-interpreter-gil-newfrom
tonybaloney wants to merge 3 commits intoericsnowcurrently:per-interpreter-gil-newfrom
Conversation
…er config flag when it has been explicitly disabled. Add value error when site is off and isolated is not true
…sub_nosite_example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just example code, but with a flag for no-site propagating down to the interpreter config, sub interpreters are 50% faster to create because
init_import_site()takes 50% of the execution time for_Py_InterpreterNewFromConfigFor cases where users want a site in the main interpreter, but don't need a site in the sub interpreters, it would be very helpful to have a flag.
I've created a benchmark to test this against sub interpreters, threading and multiprocessing (skip those other 2 to just see a comparison to sub interpreters).
If you like this idea I'm happy to submit a proper PR with tests.