Refactor proposal: use an extraWeigth mapping #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ernestognw
reviewed
Jun 11, 2025
Owner
ernestognw
left a comment
ernestognw
left a comment
There was a problem hiding this comment.
Looks good. The only thing I'd like to preserve is a single function that emits ERC7913SignerWeightChanged rather than having duplicated code. I'll update and merge
ernestognw
merged commit 357aece
into
ernestognw:feature/multisig-weighted
11 of 13 checks passed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal here is to avoid the current memory copy and loop in
totalWeightPR Checklist
npx changeset add)