Improve Server Max Bit Rate Violation Messaging To Client #1931
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE NOTE the following text from the iperf3 license. Submitting a
pull request to the iperf3 repository constitutes "[making]
Enhancements available...publicly":
The complete iperf3 license is available in the
LICENSEfile in thetop directory of the iperf3 source tree.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies: masterIssues fixed (if any): Allow server-side to enforce rate-limits to avoid possible DoS and protect iperf Daemon #937
Brief description of code changes (suitable for use as a commit message):
As per the ongoing discussion in iperf/#1684, as part of an effort to enhance the user experience of
iperf3clients, the enhancement proposed is to validate the client's input parameter for--bitratewhen it is set and reject the measurement when it violates the server's configured--server-bitrate-limitvalue. When the client does not provide a limit and the test violates the configured bit rate, then the server should send an informative message to the client to indicate why the test was abruptly stopped.Client's Requested Bit Rate Exceeds Server's Max
server
client
./src/iperf3 -c 127.0.0.1 --time 5 --parallel 4 --bitrate 10Mbit/1sec Connecting to host 127.0.0.1, port 5201 iperf3: error - client's requested bit rate exceeds the server's bitrate limitClient's Bit Rate Exceeds Server's Max Circumstantially
server
client