Skip to content

Conversation

@vaidastal
Copy link

@vaidastal vaidastal commented May 23, 2025

Brief description of the changes

New device temp-1w8-pro. This instrument is designed to measure temperature using up to 8 Dallas DS18B20 sensors simultaneously. Expecting Made for ESPHome.

Type of changes

  • New device
  • Update existing device
  • Removing a device
  • General cleanup
  • Other

Checklist:

  • There are no passwords or secrets references in any examples.
    The only exceptions are !secret wifi_ssid and !secret wifi_password.
  • The wifi or ethernet block has no static / manual ip address specified.
  • The first configuration provided should be hardware definitions only.
    A more involved example can be provided in a separate configuration block.

Made for ESPHome Checklist

  • Project is powered by an ESP32 or supported variant such as C3, C6, S2, S3 etc
  • Project is using ESPHome firmware
  • Project name cannot contain ESPHome except in the case of ending with for ESPHome
  • ESPHome configuration is open source and available for end users to modify/update
  • If the device uses Wi-Fi
    • configuration contains esp32_improv:
    • configuration contains improv_serial: if there is a USB port
  • Users should be able to apply updates to your device.
    • Device can be "taken control" of by the user using the ESPHome Builder
      • Configuration includes dashboard_import: to facilitate this
      • Configuration contains ota.esphome component.
      • Serial flashing is not disabled
      • There are no references to secrets in the configuration
      • There are no passwords in the configuration
      • There are no static IP addresses in the configuration
      • The configuration must be valid, compile and run successfully without any user changes after taking control
      • Every entity/component (sensor, switch, etc) must have an id defined
    • OTA Updates are provided via the update.http_request component.

@netlify
Copy link

netlify bot commented May 23, 2025

Deploy Preview for esphome-devices ready!

Name Link
🔨 Latest commit c4237e2
🔍 Latest deploy log https://app.netlify.com/projects/esphome-devices/deploys/683539b04239480008f727f7
😎 Deploy Preview https://deploy-preview-1104--esphome-devices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🔴 down 2 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 89 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@jesserockz jesserockz added made-for-esphome-pending Pending approval for Made for ESPHome made-for-esphome labels May 26, 2025
@jesserockz jesserockz removed made-for-esphome made-for-esphome-pending Pending approval for Made for ESPHome labels May 27, 2025
@github-actions github-actions bot added made-for-esphome-pending Pending approval for Made for ESPHome made-for-esphome labels May 27, 2025
@github-actions
Copy link

This PR has been labeled as Made for ESPHome and is pending review. Please ensure you complete the checklist added to the description above.

@vaidastal
Copy link
Author

vaidastal commented May 27, 2025

Hi, thanks for update and review list. Appreciate that.

I have updated list, but I left a couple of options that I either did not find earlier or not sure what that means.

  1. esp32_improv as far as I understand that is not necessary if device can be flashed via serial. At least I understood that way. I used improv_serial instead.

  2. Device can be "taken control" of by the user using the ESPHome Builder

Not sure, what ESPHome Builder is, to be honest. Are we talking about ESPHome dashboard with all units listed with yaml editor?

  1. OTA Updates are provided via the update.http_request component.

We will not provide updates for yaml file. We will send devices pre-flashed and basically the whole idea is to have out-of-the-box usage even without ESPHome. Users can add them via dashboard and then it will be downloaded as far as I understand with dashboard_import feature. Do we have to apply updates?

Thanks for your time.

@vaidastal
Copy link
Author

Hey,

Is this now on me or pending state means that additional reviews have to be made by ESPHome? I just would like to make sure that I have not missed anything.

Thanks.

@vaidastal
Copy link
Author

Hey,

we updated our repo https://github.com/makerspacelt/temp-1w8-pro with guidelines for new users. Very first lines with instruction are at the top of README. We created separate repo with github workflows you asked. It seems to be working.

However, we cannot implement improv with BLE as with esp32 C3 it simply does not work. C3 has issues with BT in general, i.e. when using wifi it does not work properly. I believe we just cannot fulfill this requirement at this point in time.

Please, let us know if there is anything more we can do. We really wish to finalize this device. Community is really eager to launch it.

Thanks

@jesserockz
Copy link
Member

jesserockz commented Jul 22, 2025

However, we cannot implement improv with BLE as with esp32 C3 it simply does not work. C3 has issues with BT in general, i.e. when using wifi it does not work properly. I believe we just cannot fulfill this requirement at this point in time.

There are many devices that implement improv_ble on a C3 chip successfully. Come join discord and maybe we can look into why its not working for you?

@jesserockz jesserockz marked this pull request as draft August 11, 2025 20:22
@vaidastal
Copy link
Author

Hey, I have made changes and also included OTA. All seems to be matching sample project repo.

Please review.

Thanks.

@vaidastal
Copy link
Author

Any news about the status?

Thanks

@vaidastal
Copy link
Author

Guys, any information?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

made-for-esphome made-for-esphome-pending Pending approval for Made for ESPHome

Projects

Status: Incoming

Development

Successfully merging this pull request may close these issues.

2 participants