Skip to content

Conversation

@jkotan
Copy link
Collaborator

@jkotan jkotan commented Sep 17, 2025

It resolves #683 by changing tests to macos 15

@ggoneiESS
Copy link
Member

It's good you are on top of this! If we are not going to keep previous OSes, then I have edited the README to reflect this.

Copy link
Member

@ggoneiESS ggoneiESS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at .github/workflows I think it might make more sense to just drop the apple-clang version from the name and instead update that file, rather than continuously updating the cmake-build and adding new profiles. We also should remove the apple-clang12 since it's not used anywhere.

If we instead keep the version like apple-clang15 then we should also keep the corresponding cmake profiles rather than rewriting.

I'd be happy to approve either version with those changes (adjusting the README appropriately)

@jkotan
Copy link
Collaborator Author

jkotan commented Sep 17, 2025

Looking at .github/workflows I think it might make more sense to just drop the apple-clang version from the name and instead update that file, rather than continuously updating the cmake-build and adding new profiles. We also should remove the apple-clang12 since it's not used anywhere.

If we instead keep the version like apple-clang15 then we should also keep the corresponding cmake profiles rather than rewriting.

I'd be happy to approve either version with those changes (adjusting the README appropriately)

Hello @ggoneiESS ,
I've just removed apple-clang12. I'm not sure if I understand correctly what is cmake profile. We currently use conan with its profile where clang version is defined.

@jkotan
Copy link
Collaborator Author

jkotan commented Sep 17, 2025

shall we use clang17 ?

@ggoneiESS
Copy link
Member

It's just the build instructions given so compilation can be done against a given OS environment easily through Conan. In theory we could just add new ones and never remove the old ones...but of course that means supporting old systems for much longer.

For the other question: I would stick with clang-15 since that still works with apple-15 and it's the highest version available to Ubuntu 22.04 without messing about with package managers: https://documentation.ubuntu.com/ubuntu-for-developers/reference/availability/llvm/

@jkotan
Copy link
Collaborator Author

jkotan commented Sep 18, 2025

It's just the build instructions given so compilation can be done against a given OS environment easily through Conan. In theory we could just add new ones and never remove the old ones...but of course that means supporting old systems for much longer.

The conan profile to my understanding allows us so select particular compiler which is used and installed or use e.g. two different once by creating matrix. So you would like to remove a selection of compiler which is used on macos?

@ggoneiESS
Copy link
Member

I think it's more making a choice between either:

  • keep all options in the cmake-build.yml, and add new ones as needed (e.g. the new macos 15 build instructions)
  • keep only the latest one or two options in cmake-build.yml for Apple, Microsoft, Linux builds, but clean up the conan/profiles folder (=> here we remove apple-clang12)

The latter choice makes life easier in the long run

@jkotan jkotan merged commit 3bece17 into master Sep 18, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update macos tests to macos-15

3 participants