-
Notifications
You must be signed in to change notification settings - Fork 22
Issue 683: change tests to macos 15 #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It's good you are on top of this! If we are not going to keep previous OSes, then I have edited the README to reflect this. |
ggoneiESS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at .github/workflows I think it might make more sense to just drop the apple-clang version from the name and instead update that file, rather than continuously updating the cmake-build and adding new profiles. We also should remove the apple-clang12 since it's not used anywhere.
If we instead keep the version like apple-clang15 then we should also keep the corresponding cmake profiles rather than rewriting.
I'd be happy to approve either version with those changes (adjusting the README appropriately)
Hello @ggoneiESS , |
|
shall we use clang17 ? |
|
It's just the build instructions given so compilation can be done against a given OS environment easily through Conan. In theory we could just add new ones and never remove the old ones...but of course that means supporting old systems for much longer. For the other question: I would stick with clang-15 since that still works with apple-15 and it's the highest version available to Ubuntu 22.04 without messing about with package managers: https://documentation.ubuntu.com/ubuntu-for-developers/reference/availability/llvm/ |
The conan profile to my understanding allows us so select particular compiler which is used and installed or use e.g. two different once by creating matrix. So you would like to remove a selection of compiler which is used on macos? |
|
I think it's more making a choice between either:
The latter choice makes life easier in the long run |
It resolves #683 by changing tests to macos 15