fix(umd): #340 pass in root instead of deps #377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow outlined UMD (Universal Module Definition) - https://github.com/umdjs/umd/blob/master/amdWeb.js Related Issues: - #340 - #284 - #307
|
in your require config ,just export angular like this shim: {
'angular':{
exports: 'angular'
},
} |
Author
|
@wonsikin I have no clue how to fix this. My pr doesn't really solve this at all. I'd personally rather not have ng-table require angular in it's dependencies list. Mostly because I'd like to setup my own paths/shim without requiring angular to be set to the module id |
|
@esvit, i think this PR is worth merging. |
|
+1 |
Collaborator
|
As of version 2.0.0 angular is now a peer dependency. Also the library is packaged with webpack which means full support for the UMD format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow outlined UMD (Universal Module Definition)
Related Issues: