-
Notifications
You must be signed in to change notification settings - Fork 115
feat: add rehearsal task for governance upgrade #1289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add rehearsal task for governance upgrade #1289
Conversation
* fix: readme file paths * feat: add rehearsal 4 noop upgrade & 08-22 governor upgrade task * fix: replaced mocked upgrade * feat: add gov upgrade simulation docs
| just --dotenv-path $(pwd)/.env execute | ||
| ``` | ||
|
|
||
| For posterity, you should make a `README.md` file in the tasks directory that contains a link to the executed transaction e.g. see [here](src/tasks/<network>/rehearsals/<rehearsal-task-name>/README.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When reviewing Superchain Ops tasks and templates, look for places that the tasks/templates can be made more robust, safer, etc. The documentation link src/tasks/<network>/rehearsals/<rehearsal-task-name>/README.md uses placeholder text instead of an actual file path with proper extension. This makes the documentation less robust as users cannot follow the link to see an actual example. To make this more robust, either provide a real example link or clarify that this is a template path that should be replaced with actual values.
| For posterity, you should make a `README.md` file in the tasks directory that contains a link to the executed transaction e.g. see [here](src/tasks/<network>/rehearsals/<rehearsal-task-name>/README.md). | |
| For posterity, you should make a `README.md` file in the tasks directory that contains a link to the executed transaction e.g. see [here](https://github.com/ethereum-optimism/superchain-ops/blob/main/src/tasks/op-mainnet/rehearsals/2023-10-25-ecotone-upgrade/README.md). |
Spotted by Graphite Agent (based on custom rule: Superchain Ops task/template review)
Is this helpful? React 👍 or 👎 to let us know.
|
|
||
| [addresses] | ||
| ProxyAdminOwner = "0x5a0Aae59D09fccBdDb6C6CcEB07B7279367C3d2A" | ||
| OptimismPortal = "0xbEb5Fc579115071764c7423A4f12eDde41f106Ed" No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When reviewing Superchain Ops tasks and templates, look for places that the tasks/templates can be made more robust, safer, etc. The configuration file is missing a newline at the end of the file (indicated by the '' character). This can cause issues with some tools and version control systems. To make this more robust, ensure the file ends with a proper newline character.
Spotted by Graphite Agent (based on custom rule: Superchain Ops task/template review)
Is this helpful? React 👍 or 👎 to let us know.
| 1. Simulate the task that executes the governor upgrade via L1 deposit transaction: | ||
|
|
||
| ```bash | ||
| cd src/tasks/eth/rehearsals/2025-11-07-R4-governor-upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The directory path in the simulation guide contains a typo. The path should be 2025-11-07-R4-governance-upgrade (matching the actual directory name created in the PR) instead of 2025-11-07-R4-governor-upgrade. This inconsistency would cause the command to fail when users attempt to follow the simulation instructions.
| cd src/tasks/eth/rehearsals/2025-11-07-R4-governor-upgrade | |
| cd src/tasks/eth/rehearsals/2025-11-07-R4-governance-upgrade |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
| 1. [rehearsal-1-welcome](./rehearsal-1-welcome/README.md) | ||
| 2. [rehearsal-2-remove-signer](./rehearsal-2-remove-signer/README.md) | ||
| 3. [rehearsal-3-nested-upgrade](./rehearsal-3-jointly-upgrade/README.md) | ||
| 4. [rehearsal-4-noop-upgrade](./rehearsal-4-noop-upgrade/README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The directory name rehearsal-4-noop-upgrade doesn't match the title in the README which describes this as a "Governor Upgrade" rehearsal. For consistency, consider renaming the directory to rehearsal-4-governor-upgrade to accurately reflect the purpose of this rehearsal task.
| 4. [rehearsal-4-noop-upgrade](./rehearsal-4-noop-upgrade/README.md) | |
| 4. [rehearsal-4-governor-upgrade](./rehearsal-4-governor-upgrade/README.md) |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
Description
This PR adds Rehearsal 4: Governor Upgrade, enabling the Security Council to practice upgrading the Optimism Governor contract through an L1 deposit.
Task Implementation
L1PortalExecuteL2Calltemplate.Documentation
Additional Changes
README.md.