cmd, p2p: Migrate p2p/simulations & p2p/testing to ethersphere/swarm, Removed cmd/p2psim #20122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadsr
requested review from
fjl,
janos,
nonsense,
zelig and
zsfelfoldi
as code owners
chadsr
changed the title
Contributor
|
I would prefer to keep those packages here. We do use them in the go-ethereum tests as well and I'm happy to keep them from bit-rotting indefinitely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates
p2p/simulationsandp2p/testingto the ethersphere/swarm repository.A motivation for this decision can be found in the complementing PR.
There were two slight complications:
p2p/rlpx_test.goutilisesp2p/simulations/pipes. To solve this,p2p/simulations/pipesremains, and is renamed top2p/pipes. If someone with more knowledge prefers another solution, I can change this.cmd/p2psimalso utilises thep2p/simulationpackage. I have removed it completely for now.Also,
CODEOWNERSwould need updating, but I feel weird doing that myself.EDIT: I missed another complication in
les/api_test.goand now I am not 100% convinced that this migration can happen as @acud had hoped.