Skip to content

Conversation

@mk-devs
Copy link

@mk-devs mk-devs commented Oct 14, 2025

Added functionality for E3DC Wallboxes connected to E3DC Portal (especially for the old E3DC CAN-BUS Wallbox)
Need updated go-rscp package 0.2.2

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The guard if phases && false effectively disables your phase‐switching code—either remove this dead branch or fully implement and test the 1p/3p logic so it isn’t hard‐disabled.
  • Consider replacing the magic literal 11000 for override available power in Enable() with a named constant or config parameter to make its purpose and units clearer.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The guard `if phases && false` effectively disables your phase‐switching code—either remove this dead branch or fully implement and test the 1p/3p logic so it isn’t hard‐disabled.
- Consider replacing the magic literal `11000` for override available power in Enable() with a named constant or config parameter to make its purpose and units clearer.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mk-devs mk-devs closed this Oct 14, 2025
@mk-devs mk-devs reopened this Oct 14, 2025
@mk-devs mk-devs force-pushed the add_e3dc_wallbox_ctrl branch from bf84e90 to 2ff29f0 Compare October 15, 2025 14:58
@andig andig added the devices Specific device support label Oct 15, 2025
@github-actions github-actions bot added the stale Outdated and ready to close label Oct 24, 2025
@mk-devs mk-devs force-pushed the add_e3dc_wallbox_ctrl branch from e498011 to f28b271 Compare October 24, 2025 14:15
@github-actions github-actions bot removed the stale Outdated and ready to close label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devices Specific device support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants