-
-
Couldn't load subscription status.
- Fork 1.1k
Add e3dc wallbox ctrl #24417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mk-devs
wants to merge
9
commits into
evcc-io:master
Choose a base branch
from
mk-devs:add_e3dc_wallbox_ctrl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add e3dc wallbox ctrl #24417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The guard
if phases && falseeffectively disables your phase‐switching code—either remove this dead branch or fully implement and test the 1p/3p logic so it isn’t hard‐disabled. - Consider replacing the magic literal
11000for override available power in Enable() with a named constant or config parameter to make its purpose and units clearer.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The guard `if phases && false` effectively disables your phase‐switching code—either remove this dead branch or fully implement and test the 1p/3p logic so it isn’t hard‐disabled.
- Consider replacing the magic literal `11000` for override available power in Enable() with a named constant or config parameter to make its purpose and units clearer.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
bf84e90 to
2ff29f0
Compare
e498011 to
f28b271
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality for E3DC Wallboxes connected to E3DC Portal (especially for the old E3DC CAN-BUS Wallbox)
Need updated go-rscp package 0.2.2