Skip to content

Conversation

@andig
Copy link
Member

@andig andig commented Oct 19, 2025

Fix #24339

@andig andig added the enhancement New feature or request label Oct 19, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `core/loadpoint_plan.go:126` </location>
<code_context>
 		return false
 	}

+	if !lp.planTime.IsZero() && lp.planTime.Before(planTime) {
+		// existing
+	}
</code_context>

<issue_to_address>
**question:** Clarify the intent of the planTime comparison logic.

The comment '// existing' is unclear. If this is a placeholder, either implement the intended logic or remove it to prevent confusion.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andig andig changed the title Planner: fix stop on overrun with mutliple plans Planner: fix charging not completed on overrun with multiple plans Oct 19, 2025
@andig andig added bug Something isn't working backlog Things to do later and removed enhancement New feature or request labels Oct 20, 2025
@Maschga
Copy link
Collaborator

Maschga commented Oct 22, 2025

wir teilen dem GetPlan mit, ob es sich aktuell um einen overrun handelt und erhalten damit den letzten statt des nächsten repeating plan zurück

Das fehlt noch, oder?

@andig
Copy link
Member Author

andig commented Oct 23, 2025

Ja, könnte eine sehr einfache Lösung sein? Da GetPlan ja an verschiedenen Stellen aufgerufen wird wäre es schick, das irgendwie minimalinvasiv zu machen.

@Maschga
Copy link
Collaborator

Maschga commented Oct 23, 2025

Ja, deine Idee klingt sehr gut.
Das sollte auch funktionieren, wenn ein Plan im Overrun ist und der Zielsoc nach oben hin geändert wird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backlog Things to do later bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repeating plans: charging stops on plan overrun

2 participants